Distribute docker container to run ATH #238

olivergondza · 2016-12-05T09:32:15Z

Add Dockerfile to build container ATH can run in - no only on ci.jenkins.io.

@rtyler, I put the form-element-path-plugin on hold as it will reuse large part of this. Please review and enable on ci.jenkins.io once you are ok with this.

@mafraba, review appreciated. Btw, this is for the first time I got ATH running in container and it seems to work fine without SHARED_DOCKER_SERVICE=true, at least for xvnc plugin test. Do I miss something?

scoheb · 2016-12-08T19:41:54Z

docs/DOCKER.md

+    ... // Checkout ATH
+    sh 'docker build --build-arg=uid=$(id -u) --build-arg=gid=$(id -g) -t jenkins/ath src/main/resources/ath-container'
+    docker.image('jenkins/ath').inside {
+        sh 'eval $(./vnc.sh > /dev/null) && ./run.sh firefox latest -Dmaven.test.failure.ignore=true -DforkCount=1 -B'


The redirection to /dev/null is not part of your change to Jenkinsfile above.

scoheb · 2016-12-09T13:41:28Z

Jenkinsfile

+        changelog scm
+
+        sh 'docker build --build-arg=uid=$(id -u) --build-arg=gid=$(id -g) -t jenkins/ath src/main/resources/ath-container'
+        docker.image('jenkins/ath').inside {


You need to add this:

String containerArgs = '-v /var/run/docker.sock:/var/run/docker.sock -v $HOME/.m2:/var/maven/.m2'

and change it to be:

docker.image('jenkins/ath').inside(containerArgs) {

Otherwise, docker ps will not be able to connect to the docker daemon and docker-based test will fail

The maven repo is shared for optimization only, right?

Yes. Forgot to mention that.

scoheb · 2016-12-09T14:23:49Z

Jenkinsfile

+        sh 'docker build --build-arg=uid=$(id -u) --build-arg=gid=$(id -g) -t jenkins/ath src/main/resources/ath-container'
+        docker.image('jenkins/ath').inside {
+            sh '''
+                eval $(./vnc.sh > /dev/null 2>&1)


I think it should be:

eval $(./vnc.sh 2>/dev/null)

otherwise the echo export BROWSER_DISPLAY=$display has no effect

vnc.sh, needs its output handling reworked I guess.

scoheb · 2016-12-09T14:27:04Z

I would also maybe adjust vnc.sh to have this code:

if [ -x "$(which vncviewer)" ] ; then
    (vncviewer $display || vncviewer localhost$display) > /dev/null &
fi

no need to execute vncviewer blindly if not installed.

mafraba · 2016-12-14T08:25:30Z

@olivergondza wrt SHARED_DOCKER_SERVICE property, I guess it can work without it as long as the docker port command returns the correct IP and the docker host and mapped ports are accessible. But it shouldn't be necessary to access the containers through mapped ports in the host anymore, since they can be accessed directly thus avoiding potential connectivity issues.

scoheb · 2017-01-03T13:10:00Z

Jenkinsfile

+    ]) {
+        changelog scm
+
+        sh 'docker build --build-arg=uid=$(id -u) --build-arg=gid=$(id -g) -t jenkins/ath src/main/resources/ath-container'


As @rtyler suggested, here is the code to make use of docker.build():

def uid = sh returnStdout: true, script: "id -u | tr '\n' ' '"
def gid = sh returnStdout: true, script: "id -g | tr '\n' ' '"

def buildArgs = "--build-arg=uid=${uid} --build-arg=gid=${gid} src/main/resources/ath-container"
docker.build('jenkins/ath', buildArgs)

olivergondza · 2017-02-15T18:12:15Z

@rtyler can you create the project on ci.jenkins.io so we get this thing moving?

rtyler · 2017-02-15T18:57:07Z

If there isn't an INFRA ticket already, please file one.

olivergondza · 2017-03-13T12:51:17Z

@rtyler ping, https://issues.jenkins-ci.org/browse/INFRA-1070

jglick

Have not personally tried it but sounds like a good idea.

jglick · 2017-03-31T20:10:49Z

vnc.sh

@@ -9,6 +9,8 @@ fi

 vncserver -kill $display
 vncserver -geometry 1750x1250 $display > /dev/null
-vncviewer localhost$display > /dev/null &
+if command -v vncviewer >/dev/null 2>&1; then


You should expose port 9042 or whatever it is, so people can attach a desktop vncviewer to the container and watch the magic happen.

jglick · 2017-03-31T20:11:57Z

Jenkinsfile

+node('highram&&docker') {
+    withEnv([
+        "JAVA_HOME=${tool jdkName}",
+        "PATH+MAVEN=${tool mavenName}/bin:${env.JAVA_HOME}/bin"


Why do we need these at all, if the build is done inside the image anyway?

jglick · 2017-03-31T20:12:33Z

Jenkinsfile

+        def gid = sh returnStdout: true, script: "id -g | tr -d '\n'"
+
+        def buildArgs = "--build-arg=uid=${uid} --build-arg=gid=${gid} src/main/resources/ath-container"
+        docker.build('jenkins/ath', buildArgs)


Assign the return value to a local variable and use in place of docker.image('jenkins/ath') below.

jglick · 2017-03-31T20:14:57Z

src/main/resources/ath-container/Dockerfile

+        openjdk-8-jdk \
+        vnc4server
+
+# Allow injecting uid and git to match directory ownership


This is sufficiently weird you had better document clearly why this is necessary.

jglick · 2017-03-31T20:17:56Z

Jenkinsfile

+        def buildArgs = "--build-arg=uid=${uid} --build-arg=gid=${gid} src/main/resources/ath-container"
+        docker.build('jenkins/ath', buildArgs)
+
+        String containerArgs = '-v /var/run/docker.sock:/var/run/docker.sock'


You might need --group-add=${gid} to make sure docker.sock is writable. Unclear to me whether that is handled already by the other tricks.

jglick · 2017-03-31T20:19:02Z

docs/DOCKER.md

+    $ eval $(./vnc.sh)
+    $ ./run.sh firefox latest -Dmaven.test.failure.ignore=true -DforkCount=1 -B
+
+Jenkinsfile:


This seems redundant. Anyone who cares can look up the Jenkinsfile for themselves.

jglick · 2017-03-31T20:20:04Z

src/main/resources/ath-container/Dockerfile

+RUN apt-get -y update && \
+    apt-get install -y \
+        curl \
+        docker.io \


You can also just download a specific client executable.

jglick · 2017-03-31T20:21:24Z

src/main/resources/ath-container/Dockerfile

+RUN touch /home/ath-user/.vnc/xstartup && chmod a+x /home/ath-user/.vnc/xstartup
+
+# Set SUID and SGID for docker binary so it can communicate with mapped socket its uid:gid we can not control. Alternative
+# approach used for this is adding ath-user to the group of /var/run/docker.sock but that require root permission we do not


Hence --group-add. Maybe.

When ATH is run against downstream update center with plugins missing, the tests will be correctly skipped. This also permits upstream tests for plugins that are not distributed in upstream UC while they are in the downstream one.

scoheb · 2017-04-20T15:21:39Z

Stole your Dockerfile and part of Jenkinsfile for use in jms-messaging-plugin. Working well now. Thanks!

olivergondza · 2017-04-21T07:13:58Z

Cool. Be prepared this will receive several updates before it is ready.

olivergondza · 2017-08-16T17:49:27Z

Let's get this merged to so see it run and fail so we can fix as we go.

olivergondza added 2 commits December 5, 2016 10:24

Distribute docker contianer to run ATH

4ea67bd

Ilustrate container usage

7741607

scoheb reviewed Dec 8, 2016

View reviewed changes

Update vnc out redirection

bbcb0a3

scoheb reviewed Dec 9, 2016

View reviewed changes

Fix vnc output and add containerargs to Jenkinsfile

9d6105a

scoheb reviewed Jan 3, 2017

View reviewed changes

olivergondza added 2 commits January 4, 2017 14:37

Delegate to docker.build step

69e8dff

Merge branch 'master' into ci.jenkins.io

57d5b0c

olivergondza mentioned this pull request Mar 13, 2017

[WIP] Upgrade to Selenium 3.3.0 #284

Closed

jglick reviewed Mar 31, 2017

View reviewed changes

jglick changed the title ~~Distribute docker contianer to run ATH~~ Distribute docker container to run ATH Mar 31, 2017

stephenc mentioned this pull request Apr 3, 2017

Use a Monte Screen Recorder from Central #296

Merged

olivergondza added 9 commits April 13, 2017 21:46

Let's see if highram have docker installed

8658c14

Address some of the Jesse's comments

327c293

highram label does not seem to be present

f89e312

Silly typo

828ea25

Do not duplicate the Jenkins file in documentation

b2261ba

Do not waste time installing docker daemon

197f522

Expose VNC port and avoid xauth warning

da824c4

Merge branch 'master' into ci.jenkins.io

39acd00

olivergondza added 2 commits April 21, 2017 09:22

Add unzip and git into ATH container

cc60e66

Avoid random failures of apt-get update

46ef7ea

olivergondza mentioned this pull request May 5, 2017

Add a Jenkinsfile for parallelized ATH runs via Pipeline #157

Closed

olivergondza merged commit 5baca37 into jenkinsci:master Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Distribute docker container to run ATH #238

Distribute docker container to run ATH #238

olivergondza commented Dec 5, 2016

scoheb Dec 8, 2016

scoheb Dec 9, 2016

olivergondza Dec 9, 2016

scoheb Dec 9, 2016

scoheb Dec 9, 2016

olivergondza Dec 9, 2016

scoheb commented Dec 9, 2016

mafraba commented Dec 14, 2016

scoheb Jan 3, 2017 •

edited

Loading

olivergondza commented Feb 15, 2017

rtyler commented Feb 15, 2017

olivergondza commented Mar 13, 2017

jglick left a comment

jglick Mar 31, 2017

jglick Mar 31, 2017

jglick Mar 31, 2017

jglick Mar 31, 2017

jglick Mar 31, 2017

jglick Mar 31, 2017

jglick Mar 31, 2017

jglick Mar 31, 2017

scoheb commented Apr 20, 2017

olivergondza commented Apr 21, 2017

olivergondza commented Aug 16, 2017

Distribute docker container to run ATH #238

Distribute docker container to run ATH #238

Conversation

olivergondza commented Dec 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scoheb commented Dec 9, 2016

mafraba commented Dec 14, 2016

scoheb Jan 3, 2017 • edited Loading

Choose a reason for hiding this comment

olivergondza commented Feb 15, 2017

rtyler commented Feb 15, 2017

olivergondza commented Mar 13, 2017

jglick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scoheb commented Apr 20, 2017

olivergondza commented Apr 21, 2017

olivergondza commented Aug 16, 2017

scoheb Jan 3, 2017 •

edited

Loading